Fixing serialization tests #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
shelly-li-sl
previously approved these changes
Aug 14, 2025
shelly-li-sl
previously approved these changes
Aug 15, 2025
tests/serializer_test.go
Outdated
| @@ -167,19 +147,21 @@ func TestSerializer(t *testing.T) { | |||
| }, | |||
| CustomSerializerString: "world", | |||
| } | |||
| // empty := Roles{} | |||
jeandelavarene
previously approved these changes
Aug 18, 2025
aarrasseayoub01
dismissed stale reviews from jeandelavarene and shelly-li-sl
via
80abad1
ting-lan-wang
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the 3 serialization tests by enforcing empty array since the json serializer turns empty array into an empty string which is equivalent to NULL in OracleDB
I'm not sure if this is the best approach, or should we have a custom json serializer implementation that would take OracleDB's specificity into consideration